Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to add data whilst series are hidden from the legend #46

Open
jokohoko opened this issue Sep 5, 2017 · 4 comments
Open

Not able to add data whilst series are hidden from the legend #46

jokohoko opened this issue Sep 5, 2017 · 4 comments

Comments

@jokohoko
Copy link

jokohoko commented Sep 5, 2017

When hiding a series in the chart using the legend buttons i think what happens is that the array of data gets copied and the selected series gets removed?
In my application i constantly add new data to the chart and thus when hiding a series that series is no longer available in the data array to add new data to.

Im am not sure how to solve it so i will just leave the buttons feature out for now, but would it not be possible to add a flag to the data array instead of just taking the data out and back in all the time?

@tarekis
Copy link
Contributor

tarekis commented Sep 13, 2017

That's indeed what happens, to be honest, I never understood why it's implemented like this. The event handler is here, you can see what happens in the code. I guess if you want that changed you could propose a PR to fix it.

@tarekis
Copy link
Contributor

tarekis commented Nov 22, 2017

@jokohoko Are you intending on writing a PR for this use-case and is this still relevant?

@jokohoko
Copy link
Author

I'm sorry, i was not able to improve this workflow and went for an alternative method whereby i have 2 graphs and just switch beween them. So i no longer use the legend filtering option.

@tarekis
Copy link
Contributor

tarekis commented Nov 22, 2017

@jokohoko Thanks, in this case, I will address this issue somewhen in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants