Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out block_opened/closed() from TxOwner #555

Open
dynaxis opened this issue Oct 16, 2020 · 0 comments
Open

Separate out block_opened/closed() from TxOwner #555

dynaxis opened this issue Oct 16, 2020 · 0 comments
Assignees
@dynaxis

Comments

@dynaxis
Copy link
Member

dynaxis commented Oct 16, 2020

We should separate out the block related methods from TxOwner in the following grounds:

  1. Some modules not implementing any Tx may serve TxOwners and may want to have chances to prepare to serve them and/or clean up after serving all.
  2. Modules implementing multiple types of Txes may get notified on block open/close only once. With TxOwners exported for all Tx types implemented by a module, all of the TxOwners will be redundantly notified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dynaxis dynaxis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dynaxis