Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Up #68

Closed
wants to merge 1 commit into from
Closed

Sign Up #68

wants to merge 1 commit into from

Conversation

jessicasu77
Copy link
Contributor

ℹ️ Issue

Closes #52

📝 Description

Briefly list the changes made to the code:

  • Added support for this.
  • And removed redunant use of that.
  • Also this was included for reasons.

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Provide screenshots of any new components, styling changes, or pages.

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

Copy link
Contributor

@thejamielin thejamielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the URL again and I no longer got that weird 2 section sign up page. Looks good to me! Thanks Jess for moving this to a PR!

Copy link
Contributor

@adriannaliu adriannaliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rymaju
Copy link
Member

rymaju commented Oct 13, 2022

Am I crazy or is this PR just a newline?

@jessicasu77
Copy link
Contributor Author

@rymaju the code is so clean that it's not even theree

lol this was a placeholder PR for changes to the Amazon Cognito user pool to allow a user to sign up for an OSL account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back-end: Sign Up
4 participants