Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Admin Notes #46

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Patch Admin Notes #46

merged 1 commit into from
Apr 16, 2023

Conversation

megandouli
Copy link
Contributor

ℹ️ Issue

Closes #36 and #34 kinda

📝 Description

Briefly list the changes made to the code:

  • Added a patch endpoint for updating the notes for a form - I think it makes more sense to have separate patch endpoints because an administrator will probably updates notes more frequently than the form fields and conceptually these seem like two separate tasks
  • Created an AdminNotes React component that supports creating new notes and viewing old notes (haven't added support for editing / deleting notes yet)

✔️ Verification

See #39 for how to set up the backend and frontend.

image

🏕️ (Optional) Future Work / Notes

Next steps:

  • Support editing / deleting notes

Copy link
Contributor

@jackielincroft jackielincroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS LOOKS SO GOOD 🥳 AND WORKS !!!! my only note would be that it might be nice to have a loading spinner for while the note is submitting?? but rly not a big deal since it seems to be pretty fast :)

@jackielincroft jackielincroft merged commit c4c0dc5 into jl-link-form Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PATCH endpoint to update a single form
2 participants