Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timesheet: UpdateTimesheet Endpoint / DB Uploads / Frontend & Backend Type Conversions #30

Open
kennedyry opened this issue May 11, 2023 · 0 comments
Assignees

Comments

@kennedyry
Copy link
Collaborator

When a user is interacting with the timesheet, we need to be saving what they are updating to our DB to allow persistence across the timesheet.

There are also differences between the frontend and backend schemas, we need conversions defined in the types for the backend for inputting and outputting what was changed with mappings.

Terms of Acceptance:

  • Backend Endpoint for updating timesheets refactored to accept the fields it will be overwriting / mutating only those. POST: timesheets and GET: timesheets for what we are retrieving.
  • Plan outline to ensure that only fields that should be overwritten are - they shouldnt be able to overwrite fields like state, etc.
  • Frontend updated to actually make the relevant API calls when updates are received.
  • Mappings defined for converting from backend to frontend fields and vice versa. This is for both retrieving and uploading timesheets. .pick and .transform in zod would be useful here.
@kennedyry kennedyry assigned circlegov and kennedyry and unassigned circlegov May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants