Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timesheet API: Refactor getUsers and add admin functionality #28

Open
izzyconner opened this issue May 7, 2023 · 1 comment
Open

Timesheet API: Refactor getUsers and add admin functionality #28

izzyconner opened this issue May 7, 2023 · 1 comment
Assignees

Comments

@izzyconner
Copy link
Collaborator

Currently, the getUsers endpoint works by querying cognito separately for each user. This has some drawbacks, especially the 30 call / second limit for the read requests.

We need to fully build out an alternative way to get all users of a certain role from Cognito, and then filter by userId on our end. This is also going to be necessary for admin functionality.

Admins should, by default, receive all companies and associated user data unless otherwise specified via companyId query. Currently, the user Controller

Finally, once these changes are in place, we should also move most of the logic into UserService out of UserController

@izzyconner
Copy link
Collaborator Author

izzyconner commented May 7, 2023

started some work, not nearly done but will push for now.

@izzyconner izzyconner self-assigned this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant