Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open to PRs? #10

Closed
deitch opened this issue Oct 1, 2023 · 6 comments
Closed

open to PRs? #10

deitch opened this issue Oct 1, 2023 · 6 comments

Comments

@deitch
Copy link
Contributor

deitch commented Oct 1, 2023

I have been using the lib this was based upon, but that hasn't been updated in well over a year, and issues and PRs are getting no attention.

I have just one PR for now, making initiator members public. Are you open to pulling that in? I would be happy to open that PR to here as well.

Thanks
@arashpayan
Copy link
Collaborator

Hi @deitch. Yes, I'm open to accepting PRs for new functionality, and making the Initiator methods public sounds good.

@deitch
Copy link
Contributor Author

deitch commented Oct 2, 2023

First one is open at #11

I have two follow-ups in mind:

  • enable linting on PRs (that would require about 45-50 listing fixes)
  • enable anonymous auth

Any objections?

@arashpayan
Copy link
Collaborator

Both of those sound good. 👍

@deitch
Copy link
Contributor Author

deitch commented Oct 3, 2023

Great. You'll see them in the coming days.

@deitch
Copy link
Contributor Author

deitch commented Oct 3, 2023

#12 for lint

@deitch deitch mentioned this issue Oct 20, 2023
Merged
@arashpayan
Copy link
Collaborator

Linting and anonymous auth are now both in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arashpayan @deitch