Reviewers: How to do a Code Review
Deployability of Changes per Deployment Policy
- 3 Required Reviews: 1 peer/buddy + 1 SME from here + 1 of your Manager OR Embedded QE
- Migration review obtained from 1 of Becky Bell, Maddy Sullivan, or Andy Chang if this PR contains a migration
- In case of unplanned/emergency deploy, +1 from Incident Manager?
- PR title is meaningful and includes JIRA ticket(s) in webhook format, ie. "[ENG-3333] Handle nil case in partner id check"
- JIRA Ticket(s):
- Design Doc (where applicable):
- Does this fix a rollbar? If so, provide Rollbar link:
- Does this fix a recently-deployed change? (within past two sprints)
- If so, please complete a miniRCA.
Will this change impact other teams' code? If so, how?
How could this change break? What would be the impact?
How did you test this locally?
How will you test this in Labs? Apps?
Do your changes handle nil cases where they might be passed in?
Rollback Plan (incl migration backout where necessary):