From 6095b7d857978223144f43a941ff894845b5eb24 Mon Sep 17 00:00:00 2001
From: Ricky de Laveaga <git@rdela.com>
Date: Fri, 2 Aug 2024 13:16:10 -0700
Subject: [PATCH 1/4] Fix: dropdown-menu highlight overview links

nav (main_nav) .dropdown-menu section.highlight links were using
nav_item.overview.title instead of nav_item.overview.link and some
of the data in main_nav.yml pointed to nonexistent pages.
---
 src/_data/main_nav.yml         | 4 ++--
 src/_includes/nav/_main.html   | 2 +-
 src/_includes/nav/_mobile.html | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/_data/main_nav.yml b/src/_data/main_nav.yml
index 317aaf5..fcbffe2 100644
--- a/src/_data/main_nav.yml
+++ b/src/_data/main_nav.yml
@@ -3,7 +3,7 @@
 		"title": "Admissions",
 		"overview": {
 			"title": "Admissions Overview",
-			"link": "/admission-overview",
+			"link": "#",
 			"media": {
 				"image": "/assets/students.jpg",
 				"alt": "Students in the admissions office"
@@ -75,7 +75,7 @@
 		"title": "Academics",
 		"overview": {
 			"title": "Academics Overview",
-			"link": "/academics-overview",
+			"link": "#",
 			"media": {
 				"image": "/assets/studying.jpg",
 				"alt": "Students studying"
diff --git a/src/_includes/nav/_main.html b/src/_includes/nav/_main.html
index 304887f..ebf54a6 100644
--- a/src/_includes/nav/_main.html
+++ b/src/_includes/nav/_main.html
@@ -12,7 +12,7 @@
   <div class="dropdown-menu" id="dropdown-{{ forloop.index }}">
 	<div class="dropdown-content" >
 	  <section class="highlight">
-		<a href="{{ nav_item.overview.title }}">
+		<a href="{{ nav_item.overview.link }}">
 		  <div class="media">
 			{% image nav_item.overview.media.image nav_item.overview.media.alt 300 %}
 		  </div>
diff --git a/src/_includes/nav/_mobile.html b/src/_includes/nav/_mobile.html
index edbb78a..e5f736b 100644
--- a/src/_includes/nav/_mobile.html
+++ b/src/_includes/nav/_mobile.html
@@ -21,7 +21,7 @@
 			<div class="dropdown-menu" id="inner-mobile-menu-{{ forloop.index }}">
 				<div class="inner-mobile-menu">
 					<section class="highlight">
-						<a href="{{ nav_item.overview.title }}">
+						<a href="{{ nav_item.overview.link }}">
 							{{ nav_item.overview.title }}
 						</a>
 					</section>

From ce15732efdf2a4fbdcb01b535054ed7903211301 Mon Sep 17 00:00:00 2001
From: Ricky de Laveaga <git@rdela.com>
Date: Tue, 20 Aug 2024 20:07:05 -0700
Subject: [PATCH 2/4] Add missing event.url

---
 component-library/components/events/events.eleventy.liquid | 2 +-
 src/index.html                                             | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/component-library/components/events/events.eleventy.liquid b/component-library/components/events/events.eleventy.liquid
index 64e14c5..13c9e86 100644
--- a/component-library/components/events/events.eleventy.liquid
+++ b/component-library/components/events/events.eleventy.liquid
@@ -15,7 +15,7 @@
                     {{ event.date }}
                 </time>
                 <div class="info">
-                    <h3><a href="">{{ event.title }}</a></h3>
+                    <h3><a href="{{ event.url }}">{{ event.title }}</a></h3>
                     <p>{{ event.time }}</p>
                 </div>
             </article>
diff --git a/src/index.html b/src/index.html
index 133d0e0..71f962a 100644
--- a/src/index.html
+++ b/src/index.html
@@ -94,15 +94,15 @@
     title: Upcoming events
     events:
       - date: Jan 15
-        url:
+        url: '#'
         title: Spring semester begins
         time: 2pm-3pm Union Hall
       - date: Feb 10
-        url:
+        url: '#'
         title: Open house
         time: 1pm-3pm Lincoln Center
       - date: Mar 5
-        url:
+        url: '#'
         title: Research symposium
         time: 10am-12pm Quad Building
     button:

From dbd695ecd02fda8bf909af3fa6e6a92faaad3d30 Mon Sep 17 00:00:00 2001
From: Ricky de Laveaga <git@rdela.com>
Date: Fri, 23 Aug 2024 09:52:58 -0700
Subject: [PATCH 3/4] Use item.link for section.items

---
 src/_includes/nav/_main.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/_includes/nav/_main.html b/src/_includes/nav/_main.html
index ebf54a6..666a06f 100644
--- a/src/_includes/nav/_main.html
+++ b/src/_includes/nav/_main.html
@@ -25,7 +25,7 @@
 		<ul>
 		  {% for item in section.items %}
 		  <li>
-			<a href="#">
+			<a href="{{ item.link }}">
 			  {{ item.title }}
 			</a>
 		  </li>

From 17fd5787d568b7b074d2b6829445b6c8b8c05867 Mon Sep 17 00:00:00 2001
From: Ricky de Laveaga <git@rdela.com>
Date: Fri, 23 Aug 2024 09:58:23 -0700
Subject: [PATCH 4/4] Also use item.link for section.items in mobile

---
 src/_includes/nav/_mobile.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/_includes/nav/_mobile.html b/src/_includes/nav/_mobile.html
index e5f736b..c31741d 100644
--- a/src/_includes/nav/_mobile.html
+++ b/src/_includes/nav/_mobile.html
@@ -31,7 +31,7 @@
 						<ul>
 						{% for item in section.items %}
 						<li>
-							<a href="#">
+							<a href="{{ item.link }}">
 							{{ item.title }}
 							</a>
 						</li>