Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't pass JDBC version in user agent #247

Open
mshustov opened this issue Jun 17, 2024 · 3 comments
Open

Doesn't pass JDBC version in user agent #247

mshustov opened this issue Jun 17, 2024 · 3 comments

Comments

@mshustov
Copy link
Member

Describe the bug

JDBC version is expected to be set in client name. actual result: metabase/1.3.3/unknown (Linux/6.1.0-12-amd64; OpenJDK 64-Bit Server VM/Temurin-11.0.22+7; HttpURLConnection; rv:unknown)

@mshustov mshustov added the bug Something isn't working label Jun 17, 2024
@chernser
Copy link

chernser commented Jun 19, 2024

Would it be a good idea to follow guidelines for the User-Agent header? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent
It means that client will add its version on its own and result would look like
metabase/1.3.3 (Linux/6.1.0-12-amd64; OpenJDK 64-Bit Server VM/Temurin-11.0.22+7;) ClickHouseJDBC/0.6.1 (HttpURLConnection; Apache HC 5.2.0)

@chernser
Copy link

Just in case here is a Java Client issue ClickHouse/clickhouse-java#1698

@slvrtrn slvrtrn added chore and removed bug Something isn't working labels Jun 19, 2024
@slvrtrn
Copy link
Collaborator

slvrtrn commented Jun 19, 2024

I will leave this open as a reminder to upgrade the JDBC driver when the fix is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants