Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the :set-timezone driver feature; allow to change the reporting timezone in the Localization settings #253

Merged
merged 17 commits into from
Jun 27, 2024
Merged

Enable the :set-timezone driver feature; allow to change the reporting timezone in the Localization settings #253

merged 17 commits into from
Jun 27, 2024

Conversation

slvrtrn
Copy link
Collaborator

@slvrtrn slvrtrn commented Jun 25, 2024 •
edited
Loading

Summary

This PR enables the :set-timezone Metabase feature so that it is now possible to change the reporting timezone in Admin -> Localization settings.

image

Resolves #200.

Excluded :convert-timezone from the scope of this PR, as :set-timezone seems to be of a higher priority, and proper :convert-timezone implementation requires additional investigation, as some tests still indicate that the implementation (currently, commented out) is not entirely correct.

:convert-timezone issue for tracking: #254

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@slvrtrn slvrtrn changed the title Enable fully fledged time zones support Enable fully fledged time zones support (:set-timezone, :convert-timezone) Jun 25, 2024
@slvrtrn slvrtrn changed the title Enable fully fledged time zones support (:set-timezone, :convert-timezone) Enable :set-timezone feature in the driver Jun 25, 2024
@slvrtrn slvrtrn mentioned this pull request Jun 25, 2024
Closed
@slvrtrn
Copy link
Collaborator Author

slvrtrn commented Jun 25, 2024

Excluded :convert-timezone from the scope of this PR, as :set-timezone seems to be of a higher priority, and proper :convert-timezone implementation requires additional time.

Created a new issue: #254

@slvrtrn slvrtrn changed the title Enable :set-timezone feature in the driver Enable the :set-timezone driver feature; allow to change the reporting timezone in the Localization settings Jun 26, 2024
@slvrtrn slvrtrn marked this pull request as ready for review June 26, 2024 20:27
@slvrtrn slvrtrn requested a review from mshustov June 26, 2024 20:34
mshustov
mshustov reviewed Jun 27, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@slvrtrn slvrtrn merged commit 9cc0399 into master Jun 27, 2024
3 checks passed
@slvrtrn slvrtrn deleted the enable-timezones-support branch June 27, 2024 11:55
@frankyso
Copy link

Hi All,
I wanted to extend a huge thank you to you and the team for enabling the timezone function in Metabase! This enhancement is incredibly useful for our workflows.

I also wanted to ask about the timeline for implementing this feature in Metabase Cloud. Could you please provide any insights or updates on when we can expect it to be available there?

@Tony-metabase
Copy link

That functionality will be available on Metabase version 50 ... Metabase Cloud is still running 1.49 ... The Cloud would be updated in the coming weeks. You should get a notification when that happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fully fledged time zones support
4 participants
@slvrtrn @frankyso @Tony-metabase @mshustov