Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capturing uncaught sign_request error and returning on callback #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Capturing uncaught sign_request error and returning on callback #267

wants to merge 1 commit into from

Conversation

theBoEffect
Copy link

adding a try/catch to sign_request call - capturing error and returning in callback rather then allowing them to go uncaught

Fixes #251
Fixes #236

adding a try/catch to saml2.coffee line 562 sign_request call - captu…
0fd158a 
…ring error and returning in callback rather then allowing them to go uncaught
@darioackermann
Copy link

Hey, I am gladly accepting PRs (again) on the revived fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error handling: avoid uncaught errors zlib callback throws error which cannot be captured by caller
2 participants
@theBoEffect @darioackermann