Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add corridor segmentation module #37

Closed
fnattino opened this issue Nov 7, 2024 · 1 comment · Fixed by #41
Closed

Add corridor segmentation module #37

fnattino opened this issue Nov 7, 2024 · 1 comment · Fixed by #41
Assignees
@fnattino

Comments

@fnattino
Copy link
Contributor

fnattino commented Nov 7, 2024

Dependent on CityRiverSpaces/rcoins#5

Once we can grow strokes from specific edges in rcoins, we should be able to implement the river corridor segmentation in R (see reference in Python: https://github.com/CityRiverSpaces/prototyping/blob/main/notebooks/segments/segments_bucharest_river-valley.ipynb).
@cforgaci
Copy link
Contributor

Consider #20 too when addressing this issue

@fnattino fnattino linked a pull request Nov 18, 2024 that will close this issue
Implement segmentation as part of the package #41
Merged
@fnattino fnattino self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnattino fnattino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement segmentation as part of the package CityRiverSpaces/CRiSp
2 participants
@cforgaci @fnattino