Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Event Log panel is broken in the recently updated version of neo-gui-developer #40

Open
mwherman2000 opened this issue Feb 19, 2018 · 7 comments
Labels

Comments

@mwherman2000
Copy link
Contributor

It worked perfectly in the previous release but whatever happened recently has broken the Event Log ...Runtime.Notify() and Runtime.Log() SC not longer produce any output in the Event Log

@mwherman2000
Copy link
Contributor Author

Updating to the latest releases of Neo and Neo.VM wasn't the answer. Two compiler time errors:

1>------ Build started: Project: neo-gui, Configuration: Debug Any CPU ------
1>D:\repos\neo-gui-developer\neo-gui\UI\InvokeContractDialog.cs(66,32,66,35): error CS1503: Argument 3: cannot convert from 'Neo.Fixed8' to 'Neo.UInt160'
1>D:\repos\neo-gui-developer\neo-gui\UI\TransferDialog.cs(120,80,120,83): error CS1503: Argument 3: cannot convert from 'Neo.Fixed8' to 'Neo.UInt160'
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

@ghost
Copy link

ghost commented Feb 19, 2018

Those errors were occurring because neo-gui-developer wasn't as up to date as Neo.VM was expecting and is unrelated to the event log not working.

I've got Runtime.Notify working again in my dev build, have not tried Runtime.Log yet. The format of the NotificationEventArgs object has changed which will require some update to the code you recently committed.

@ghost ghost self-assigned this Feb 19, 2018
@ghost ghost added the bug label Feb 19, 2018
@mwherman2000
Copy link
Contributor Author

I don't mind re-applying my changes. What are the best next steps? Should I wait until you've pulled your changes into master? Do you have an ETA? Please suggest a path to follow. Thank you for running this down @birmas

@mwherman2000
Copy link
Contributor Author

For the historical record, this bug is a regression. It happened once before: neo-project/neo#98

@ghost
Copy link

ghost commented Feb 19, 2018

Actually it was never addressed and that is why neo-gui-developer has been lagging behind neo-gui!

I made a commit last night which allows the runtime notify event handler to be called again, just the formatting of the event args object had changed.

Will try and look at it again tonight after work, feel free to take a look at it if you have time 👍

@mwherman2000
Copy link
Contributor Author

mwherman2000 commented Feb 20, 2018

When I put a break point on entry into the StateReader_Notify() event handler, it's still not being called. I did a fresh pull this morning git pull https://github.com/CityOfZion/neo-gui-developer.git.

@ghost
Copy link

ghost commented Feb 21, 2018

As discussed in discord, this issue is still being addressed.

Anyone else experiencing the same issue can, for the time being, use a dev branch located: https://github.com/birmas/neo-gui-developer/tree/dev-updates

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant