Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reservation unit text search to use AND instead of OR #1459

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

matti-lamppu
Copy link
Collaborator

🛠️ Changelog

  • This works more like the previous search, with the omission of commas being used to search in OR-fashion (not used based on search history)
  • Should likely be changed back to OR when we have a "similarity" ordering so that results containing more of the given words are shown first, but those that contain some of them can still be shown (This should also weigh finding the search word from
    the name of the reservation unit more than from the description for example)

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

@matti-lamppu matti-lamppu self-assigned this Dec 10, 2024
@matti-lamppu matti-lamppu added the fix Fixes a bug label Dec 10, 2024
@matti-lamppu matti-lamppu marked this pull request as ready for review December 10, 2024 06:59
Copy link

sonarcloud bot commented Dec 10, 2024

@matti-lamppu matti-lamppu merged commit a7909d9 into main Dec 10, 2024
7 checks passed
@matti-lamppu matti-lamppu deleted the change-search-to-and-based branch December 10, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants