Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Seasonal Reservation Validation #1438

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ranta
Copy link
Collaborator

@ranta ranta commented Nov 18, 2024

🛠️ Changelog

  • Add validation for Seasonal Reservation cancellation endpoint
  • Rename ReservationDeleteMutation endpoint in the GraphQL API
    • Old endpoint is still available, but marked as deprecated. It should be removed after frontend is updated.

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@ranta ranta added the improvement Improves an existing feature label Nov 18, 2024
@ranta ranta self-assigned this Nov 18, 2024
@ranta ranta force-pushed the cancel-single-seasonal-reservation branch 5 times, most recently from 05a4960 to 046f840 Compare November 21, 2024 08:19
Deprecated `deleteReservation` endpoint in favour of the more descriptive `deleteTentativeReservation`
@matti-lamppu matti-lamppu force-pushed the cancel-single-seasonal-reservation branch from 046f840 to f44c8e7 Compare November 21, 2024 08:31
@matti-lamppu matti-lamppu enabled auto-merge (rebase) November 21, 2024 08:31
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@matti-lamppu matti-lamppu merged commit 9acf72b into main Nov 21, 2024
4 of 5 checks passed
@matti-lamppu matti-lamppu deleted the cancel-single-seasonal-reservation branch November 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants