Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more filter options to unitsAll endpoint #1467

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

ranta
Copy link
Collaborator

@ranta ranta commented Dec 11, 2024

🛠️ Changelog

  • Adds only_with_permission,published_reservation_units,only_direct_bookable,only_seasonal_bookable filters to unitsAll endpoint
  • Fixes name filter not returning results with partial search string

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

vergama
vergama previously approved these changes Dec 12, 2024
matti-lamppu
matti-lamppu previously approved these changes Dec 12, 2024
Copy link
Collaborator

@matti-lamppu matti-lamppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment is in the wrong place IMO but nothing else

@ranta ranta dismissed stale reviews from matti-lamppu and vergama via 23b6c73 December 12, 2024 08:37
@ranta ranta force-pushed the unit-all-endpoint-filters branch from e1e287f to 23b6c73 Compare December 12, 2024 08:37
@ranta ranta enabled auto-merge (rebase) December 12, 2024 08:37
Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ranta ranta requested a review from matti-lamppu December 12, 2024 11:11
@ranta ranta merged commit b9fef96 into main Dec 12, 2024
5 of 6 checks passed
@ranta ranta deleted the unit-all-endpoint-filters branch December 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants