Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search vector update #1457

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix search vector update #1457

merged 1 commit into from
Dec 4, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Dec 4, 2024 •
edited
Loading

🛠️ Changelog

  • Add output fields and better null-catching to pass vector updates in test server

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

@matti-lamppu
Fix search vector update
c140bb4 
Add output fields and better null caching
@matti-lamppu matti-lamppu added the fix Fixes a bug label Dec 4, 2024
@matti-lamppu matti-lamppu self-assigned this Dec 4, 2024
@matti-lamppu matti-lamppu marked this pull request as ready for review December 4, 2024 14:22
@matti-lamppu matti-lamppu enabled auto-merge (rebase) December 4, 2024 14:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@matti-lamppu matti-lamppu merged commit aa901ce into main Dec 4, 2024
6 of 7 checks passed
@matti-lamppu matti-lamppu deleted the fix-search-vector-update branch December 4, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatank joonatank joonatank approved these changes

@ranta ranta Awaiting requested review from ranta

@vergama vergama Awaiting requested review from vergama

Assignees

@matti-lamppu matti-lamppu

Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matti-lamppu @joonatank