Implement parkings data export capability #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HotStew
changed the title
HotStew
changed the title
HotStew
force-pushed
the
export-parkings-data
branch
2 times, most recently
from
910b4ee to
125959e
Compare
|
Oops, closed this by accident while closing some some cruft PRs in bulk. |
|
You shouldn't use f-strings, since they are not supported with Python 3.5. Please fix the style issues too. |
HotStew
force-pushed
the
export-parkings-data
branch
2 times, most recently
from
f27050d to
c3f7a0f
Compare
suutari-ai
reviewed
May 24, 2022
Comment on lines
+14
to
+16
| class CSVRenderer(renderers.BaseRenderer): | ||
| media_type = "text/csv" | ||
| format = "csv" | ||
| render_style = 'binary' | ||
|
|
There was a problem hiding this comment.
I think you should use a ready-made DRF CSV renderer rather than implementing your own.
There's at least https://github.com/mjumbewu/django-rest-framework-csv which should do the job.
added 8 commits
May 24, 2022 17:39
New endpoints: - /monitoring/v1/export/download/ Responds with a string that contains all the csv lines. Start time and end time are required fields. Create a custom CSVRenderer for this endpoints. When it comes to filtering data with the time we do it by having a time range where any parking that was active during the range gets exported. This means that any parking that started before range and ended before range OR started after range will not get filtered in. One important thing to mention is that if the queryset ends up being very big (>100k objs) ram usage may suffer and the user will have to wait a long time for a response from the server since we don't stream the response.
In a case of an action that uses the CSVRenderer raises an exception, change the renderer to a JSONRenderer so the server can respond with an error message with correct data format. We have to bypass the custom CSVRenderer because otherwise the validation error message gets passed over to the CSVRenderer and the CSVRenderer can't really do anything with the error message.
Expose custom header 'x-suggested-filename' so that the dashboard can use it for naming the csv file.
Also create a utility download function that downloads the CSV file as a blob.
Operators and PaymentZones get stored in root state.
Create Export component. Create new 'onMount' dispatch. This calls the 'fetchData' function. The data in question which is Operators and Payment zones only need to get fetched once.
HotStew
force-pushed
the
export-parkings-data
branch
from
c3f7a0f to
e1d76f7
Compare
suutari-ai
reviewed
May 24, 2022
Comment on lines
+24
to
+49
| kwargs = { | ||
| "time_start__lte": time_end, | ||
| "time_end__gte": time_start, | ||
| } | ||
|
|
||
| if payment_zones: | ||
| kwargs["zone__code__in"] = payment_zones | ||
| if operators: | ||
| kwargs["operator__id__in"] = operators | ||
|
|
||
| parkings = ( | ||
| Parking.objects | ||
| .filter(**kwargs) | ||
| .order_by("-time_start") | ||
| .prefetch_related("operator", "zone") | ||
| ) | ||
|
|
||
| if parking_check: | ||
| parking_check_parking_ids = ( | ||
| ParkingCheck.objects | ||
| .filter(found_parking__id__in=parkings) | ||
| .order_by("found_parking") | ||
| .values_list("found_parking") | ||
| .distinct() | ||
| ) | ||
| parkings = parkings.filter(id__in=parking_check_parking_ids) |
There was a problem hiding this comment.
The filtering code here doesn't seem to belong to the CSV renderer, but rather to the ViewSet, or even better they should be implemented as FilterSets. See e.g. parkings/api/enforcement/valid_parking.py for an example of FilterSet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export button to toggle options rendering
Nothing selected, start & end time automatically set.
Filters selected
CSV file
Task requirements:
Export parkings data to CSV file.
Comments