Add a dependency for the version map. #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code change looks good to me. The GitHub builds all passed as well. I would not have been surprised it caused some issue on Windows... but it seems happy enough. I would like to rebase it to add Jenkins CI changes to work with changes to our CI infra and see it pass there. But I'm optimistic it'll pass just fine. Thank you for the PR @sebastianas |
Add a dependcy on that version map so that it is re-run once it changes. Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
micahsnyder
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dependency on that version map so that it is re-run once it changes.
This has been missed in the initial pull request.