Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDA pro compatibility tweaks #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wideglide
Copy link

  • use universal idaapi.qexit
  • IDA 7.4+ uses idc.get_func_attr instead of idc.GetFunctionAttr1
  • ensure byte/string compatibility for Python 2/3
  • sort nodes/edges to help tests pass

With these changes, the unit tests for the IDA scripts pass for IDA Pro versions 7.2 - 8.1. This is using Python2 for v7.2 and Python3 for v7.4+, but they should be interchangeable.

- use universal `idaapi.qexit`
- ensure byte/string compability for Python 2/3
- sort nodes/edges to help tests pass

With these changes, the unit tests for the IDA scripts pass for IDA Pro versions 7.2 - 8.1.
This is using Python2 for v7.2 and Python3 for v7.4+, but they should be
interchangable.
@jimmy-sonny jimmy-sonny added the enhancement New feature or request label Oct 31, 2022
@jimmy-sonny
Copy link
Contributor

Thank you for your contribution @wideglide. I'll review your changes and merge them.

- `idaapi.ua_mnem` is available since v6.1
- `idaapi.qexit` is available since v6.1
- `procName` is not deprecated and issues a warning now.
  `info.procname` is available in versions 7+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants