Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better names for syncAddress jobs #69

Open
llunaCreixent opened this issue Apr 9, 2021 · 2 comments
Open

Find better names for syncAddress jobs #69

llunaCreixent opened this issue Apr 9, 2021 · 2 comments

Comments

@llunaCreixent
Copy link
Member

See the code: https://github.com/CirclesUBI/circles-api/blob/main/src/worker.js#L47

So far the transfer jobs are named syncAddress-transfer-${address}-${Date.now()} and the trust jobs are named syncAddress-trust-${topics[1]}-${Date.now()}.
This name pattern might produce different jobs with the same name. A better name pattern could include the transaction hash, which is unique.

@ana0
Copy link
Contributor

ana0 commented Apr 9, 2021

Just fyi, the transaction hash is not guaranteed to add uniqueness for these either - one transaction can generate any number of log messages. Log indexes (the number) per transaction hash is guaranteed to be unique though

@adzialocha
Copy link
Collaborator

This might be related: #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants