Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transitive transaction tests to reflect trust-graph specification #48

Open
ana0 opened this issue Feb 4, 2021 · 1 comment
Open
Labels

Comments

@ana0
Copy link
Contributor

ana0 commented Feb 4, 2021

After PR CirclesUBI/circles-core#24 in the circles-api repo is merged, core tests should be added to reflect the test cases in the specification notes

The closest thing we have to e2e/integration tests is in the core tests, therefore I think this may make most sense here

@adzialocha adzialocha transferred this issue from CirclesUBI/circles-core Feb 5, 2021
@adzialocha
Copy link
Collaborator

We've decided to move the tests into circles-api as it will be more thorough to actually test against the edges.json contents. Going throught the circles-core we would only be able to test if a transaction succeeded or not which covers parts of what we want to test but not everything.

Also, the test setup in circles-api is not far: A mocked graph exists and we can mock the blockchain with ganache-core, the indexing methods in the api can be called directly.

Related PR: #49

@adzialocha adzialocha linked a pull request Feb 5, 2021 that will close this issue
9 tasks
@adzialocha adzialocha added the enhancement 🎇 New feature or request label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants