Skip to content
This repository has been archived by the owner on Mar 23, 2020. It is now read-only.

When used with dev-server (hot-reload) the plugin causes infinite reload loop #9

Open
akincel opened this issue Nov 27, 2018 · 1 comment

Comments

@akincel
Copy link
Contributor

akincel commented Nov 27, 2018

What:

  1. The plugin is started, downloads translation files, and stores them into the source tree
  2. That triggers hot-reload within the dev-server, going back to step 1.

How to fix:

  • a) there is already option skipDevelopmentUpdate which disables the plugin when running in dev-server mode
  • b) from @Igrom

The plugin could do one more thing: it could update the files conditionally (i.e., if they differ)
We could think of whether that would make the skipDevelopmentUpdate obsolete

@Igrom
Copy link
Collaborator

Igrom commented Nov 27, 2018

To potential readers of this issue: I emphasize that this has already been solved by means of an optional boolean configuration parameter introduced in #3. Set-ups which encounter this issue should set this boolean to true.

This particular issue is more aimed towards investigating whether incorporating a related solution into the default behaviour of the plugin is viable, i.e., if it does not potentially break other people's existing workflows.

akincel added a commit to akincel/cimpress-translations-webpack-plugin that referenced this issue Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants