Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPhone models #9

Open
neodave opened this issue Jan 21, 2020 · 2 comments
Open

iPhone models #9

neodave opened this issue Jan 21, 2020 · 2 comments
Labels
bug
Milestone
1.4.1

Comments

@neodave
Copy link

neodave commented Jan 21, 2020

Your list of out phone models is out of date for TouchID exclusion. You need to add the iPhone 11 models. Here is the code to insert

"iPhone11,4", "iPhone11,6", // iPhone XS Max
"iPhone12,1", // iPhone 11
"iPhone12,3", // iPhone 11 Pro
"iPhone12,5" // iPhone 11 Pro Max
@Chris-Corea
Copy link
Owner

Hey thanks! Feel free to open a PR with the new models; I'll approve and merge ASAP.

Otherwise I'll try to get to adding the new models hopefully in the next day or two.

@Chris-Corea Chris-Corea added this to the 1.4.1 milestone Jan 29, 2020
@neodave
Copy link
Author

neodave commented Jan 29, 2020

I am not where I can create a PR right now, but happy I could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
2 participants
@Chris-Corea @neodave