Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated Coverage Report for FE & BE #244

Closed
wants to merge 10 commits into from
Closed

Conversation

chetan2298
Copy link
Contributor

PR to check github action behaviour

This PR combines FE and BE tests and coverage to run in a single job

@chetan2298
Copy link
Contributor Author

This commit combines FE and BE tests and coverage report in a single job

272295a

@chetan2298 chetan2298 changed the base branch from consolidated2 to main May 13, 2023 09:27
@chetan2298 chetan2298 changed the title Test PR Consolidated Coverage Report for FE & BE May 13, 2023
@sourabhk25 sourabhk25 requested review from sourabhk25 and removed request for sourabhk25 May 16, 2023 05:03
Copy link
Contributor

@sourabhk25 sourabhk25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Combined coverage report and Separate Coverage reports were created in different folders as well.
Subtasks tested -
a) Backend and Frontend single coverage report -
image

b) Coverage Report folder created in docs folder -
Screen Shot 2023-05-15 at 10 13 51 PM

c) Only typescript files should be scanned -
image

@sourabhk25 sourabhk25 requested a review from G1411 May 16, 2023 05:35
@chetan2298 chetan2298 linked an issue May 16, 2023 that may be closed by this pull request
5 tasks
Copy link

@G1411 G1411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-05-15 at 10 46 01 PM

Just ran it and it looks like its hitting all the three points correctly!

@chetan2298 chetan2298 closed this May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate documentation/reports with coverage
4 participants