Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note for bugs #7

Open
ChiaMineJP opened this issue Jun 16, 2021 · 0 comments
Open

Note for bugs #7

ChiaMineJP opened this issue Jun 16, 2021 · 0 comments

Comments

@ChiaMineJP
Copy link
Member

chia-blockchain

1. chia/rpc/wallet_rpc_api.py

Maybe just a typo

if not isinstance(request["amount"], int) or not isinstance(request["amount"], int):

image

It is not obvious whether request["fee"] is Optional.
image

2. chia/rpc/farmer_rpc_api.py, chia/harvester/harvester_api.py,

It seems response could not be harvester_protocol_ResponsePlots for data format incompatibility.
I think format of response contains binary stream data, but later it is assumed to be a python dict.

image

image

image

3. chia/rpc/full_node_api.py

sync_tip_height seems always having value, so need not to be Optional

image

4. chia/protocols/pool_protocol.py

Shouldn't TGetFarmerRequest be here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant