You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Test files except for js-bindings/tests/test.js has been long deprecated and no longer used for a while, including GitHub Actions.
So I want to remove those legacy test files to lower management cost.
Currently I just renamed js-bindings/tests to js-bindings/tests_old.
Clear js_build folder on every build
Current building mechanism is like copy and paste. Files removed in source dir are left undeleted on build dir.
It is necessary to clear all contents in build dir before building js files.
Use only npm and ignore yarn.
In js_test.sh, there are lines which inspect whether yarn command is installed on the system, and if not, choose npm command as a package manager.
It is great for yarn users. I personally love yarn very much, as it is very fast.
However, only one of package-lock.json of npm or yarn.lock of yarn can be stored as a depenency-lock file in this repository because they conflicts.
So I choose npm as a package manager here because having yarn on a system is a optional while npm is not.
Add jest to test framework
Adopting well-known test framework can attract more people to write test code.
Changelog
Fixed incorrect toolchain file path in
js_build.sh
incorrect:
cmake ../ -DCMAKE_TOOLCHAIN_FILE=$(realpath $(which emcc))/cmake/Modules/Platform/Emscripten.cmake
correct:
cmake ../ -DCMAKE_TOOLCHAIN_FILE=$(dirname $(realpath $(which emcc)))/cmake/Modules/Platform/Emscripten.cmake
Remove deprecatated js tests
Test files except for
js-bindings/tests/test.js
has been long deprecated and no longer used for a while, including GitHub Actions.So I want to remove those legacy test files to lower management cost.
Currently I just renamed
js-bindings/tests
tojs-bindings/tests_old
.Clear
js_build
folder on every buildCurrent building mechanism is like copy and paste. Files removed in source dir are left undeleted on build dir.
It is necessary to clear all contents in build dir before building js files.
Use only npm and ignore yarn.
In
js_test.sh
, there are lines which inspect whetheryarn
command is installed on the system, and if not, choosenpm
command as a package manager.It is great for yarn users. I personally love
yarn
very much, as it is very fast.However, only one of
package-lock.json
ofnpm
oryarn.lock
ofyarn
can be stored as a depenency-lock file in this repository because they conflicts.So I choose
npm
as a package manager here because havingyarn
on a system is a optional whilenpm
is not.Add
jest
to test frameworkAdopting well-known test framework can attract more people to write test code.
Simplify test execution
Prerequisite
You need to have NodeJS and emscripten installed on your system.
For emscripten installation see https://emscripten.org/docs/getting_started/downloads.html
cd bls-signatures ./js_build.sh
The text was updated successfully, but these errors were encountered: