Ansible VSNext #47
Merged
Ansible VSNext #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkp-majds
reviewed
Dec 30, 2024
|
|
||
| DOCUMENTATION = """ | ||
| --- | ||
| module: cp_gaia_virtual_system |
There was a problem hiding this comment.
make it as module name cp_gaia_virtual_gateway
| @@ -203,7 +211,8 @@ def main(): | |||
| primary=dict(type='str'), | |||
| lacp_rate=dict(type='str', choices=['slow', 'fast']), | |||
| mode=dict(type='str', choices=['round-robin', 'active-backup', 'xor', '8023AD']), | |||
| mii_interval=dict(type='int') | |||
| mii_interval=dict(type='int'), | |||
| virtual_system_id=dict(type="int", required=False) | |||
There was a problem hiding this comment.
if it is relevant to all modules
so add it in
https://github.com/CheckPointSW/CheckPointAnsibleGAIACollection/blob/master/plugins/module_utils/checkpoint.py#L44
| - Manages virtual gateway on Check Point gateways including creating, updating and removing virtual systems. | ||
| - All operations are performed over Web Services API. | ||
| version_added: "2.9" | ||
| author: "Jafar Atili (@chkp-jafara)" |
| description: | ||
| - Manages virtual gateway on Check Point gateways including creating, updating and removing virtual systems. | ||
| - All operations are performed over Web Services API. | ||
| version_added: "2.9" |
There was a problem hiding this comment.
update to correct version of our collection
chkp-majds
reviewed
Dec 30, 2024
chkp-majds
reviewed
Dec 31, 2024
| @@ -153,7 +157,7 @@ | |||
| def main(): | |||
| # arguments for the module: | |||
| fields = dict( | |||
| enabled=dict(type='bool'), | |||
| enabled=dict(type='bool') | |||
| @@ -98,7 +106,7 @@ def main(): | |||
| fields = dict( | |||
| limit=dict(type="int", required=False, default=50), | |||
| offset=dict(type="int", required=False, default=0), | |||
| order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC"), | |||
| order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC") | |||
There was a problem hiding this comment.
maybe the comma in ansible is required after the parameter
please check it if it is working or return what was before
| @@ -80,7 +84,7 @@ def main(): | |||
| fields = dict( | |||
| limit=dict(type="int", required=False, default=50), | |||
| offset=dict(type="int", required=False, default=0), | |||
| order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC"), | |||
| order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC") | |||
| @@ -98,7 +106,7 @@ def main(): | |||
| fields = dict( | |||
| limit=dict(type="int", required=False, default=50), | |||
| offset=dict(type="int", required=False, default=0), | |||
| order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC"), | |||
| order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.