-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default local r9k keybinding per macOS standard #5764
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ctrl+H is a perfectly good bind for every other OS, I don't want it changed for any other system.
This doesn't change anything on Windows or Linux, so it's fine. I don't know about common macOS key binds, so I can't comment on the chosen bind. |
I didn’t think a tremendous amount about the keymap, just settled on something that works and is easily pressable. The only other option I considered is `Cmd` + `,`, but this is also reserved to open settings interfaces on macOS. I figured if something more mnemonic is considered in the future, this can always be changed again
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that setting a hotkey to one of the macOS "system" bindings is wrong.
However, I think I would prefer to not set a hotkey in this specific scenario for macOS, rather than adding a macOS-specific hotkey.
macOS users can still add a custom hotkey to the "toggle local r9k" action as they see fit.
I agree that it is a bit silly to have one specific default hotkey be different for one specific subset of users. Still, I would argue that the given solution is best. The only other "solution" I can think of at the moment that would address each of this PR's reviews would be to set the following attribute, which modifies Qt's default behavior of swapping
However, this is a terrible solution, mainly because this affects existing configurations. It also presents the same exact issue that this PR aims to solve, as Another possible solution was my original commit, that simply changed the hotkey for all systems, but I agreed with the other reviewers that a macOS-specific issue shouldn't affect non-macOS behavior. I also felt that replacing
Of course. They can do this whether the given solution is implemented or not. The issue that this PR aims to solve, though, is that macOS users are forced to configure this manually should they want to utilize this feature. |
If this was a more used feature I would agree to consider a macOS binding for it, but adding it adds complexity to all future hotkeys that I want to avoid unless necessary |
fixes #5711
#5711 is labelled as a bug, but this behavior is intended (source) (source)
easiest fix is to change the default local r9k keymap. while
Ctrl
/Cmd
+H
is a more mnemonic keymap, I do not think it is mnemonic enough to be worth making all macOS users have to configure this setting manually.