Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMEMO key trust setting is not saved #1135

Closed
sicherist opened this issue Jul 20, 2019 · 15 comments · Fixed by #1139
Closed

OMEMO key trust setting is not saved #1135

sicherist opened this issue Jul 20, 2019 · 15 comments · Fixed by #1139

Comments

@sicherist
Copy link
Contributor

Hello, I encountered the following problem in Chatsecure IOS version 4.3.8 (142)

My contact uses two devices for XMPP with OMEMO (Android Conversations and Linux Gajim). But he only receives my messages on one of the two devices . If he sends me a message from the other device I see the "something changed (...) compare codes" messages in Chatsecure and when I tap "compare codes" I can see that one of his omemo keys is "TOFU" but the switch on the other key is disabled (grey). If I enable the switch to trust the key and tap "save", the setting is apparently not stored. If I go back to the "compare codes" setting, the key is disabled again.

@chrisballinger
Copy link
Member

Does the other key say "Removed from Server"?

@sicherist
Copy link
Contributor Author

No, it looks like this:
IMG_20190720_203924

@chrisballinger
Copy link
Member

Yikes, looks like we've got some layout issues for that localization. Can you translate that text for me?

@sicherist
Copy link
Contributor Author

It says "OMEMO: 3 hours ago" "Not trustworthy device". Another problem with this screen is (at least here on my wives Iphone SE), if you tap the grey switch in portrait mode, the dialog opens asking what to do with the key (copy, save, mail, ect.) - just like if you tap on the key itself. I can only flip the switch in landscape mode.

@sicherist
Copy link
Contributor Author

It might be the same Problem as this one: #1119

By the way the ""something changed..." message is not localized although the transifex website says "0 strings to translate".

@ghost
Copy link

ghost commented Jul 26, 2019

I can replicate this issue (and the one referenced by @sicherist) too.

@milkywade
Copy link

milkywade commented Jul 28, 2019

I have the same issue. Happened when I was testing a user's account with Gajim before installing it on user's phone and sending test messages from that account to myself. I reinstalled Chatsecure on my phone and it seems to work fine now. Also, because of the issue OMEMO messages would not be delivered which was a pain as I thought the user was receiving them (I'm a recent user of chatsecure and was not sure about how the delivery notifications worked as there is no app documentation).

@sicherist
Copy link
Contributor Author

I can confirm that reinstalling chatsecure is a workaround.

@milkywade
Copy link

milkywade commented Jul 30, 2019

Well, I did that and now when I get a message from another contact, I get the push alert but when I open the Chatsecure application, I can not see the actual message: I can send messages fine but I won't see any messages received.
The server does not seem to be the issue as when I log in with the same account using gajim, I can see the messages.
***Edit -> non-issue: when reinstalling the other party has to accept you new omemo key.

@a11fruitless
Copy link

I am seeing this same issue as well. Reinstalling ChatSecure helped significantly. Except that changes your OMEMO key of course.

When I toggle the switches to change them from TOFU to Verified and save, when I open that screen back up everything is back to TOFU.

@chrisballinger
Copy link
Member

Can you confirm that reinstalling fixes the issue permanently?

@milkywade
Copy link

It does not.

A and B use chatsecure on iOS. A also uses gajim. A sends a message from gajim to B. A also sends some messages to B using Chatsecure. Even if A and B accept all OMEMO keys from each other, B does no longer get any messages from B on chatsecure as the setting is not saved and Chatsecure keeps on saying that "something has changed". It's a bit of a nightmare really.

@chrisballinger
Copy link
Member

I was able to reproduce this issue. It was likely caused by a regression in the XLForm library 4.0.1 update: xmartlabs/XLForm#1052

Looking into mitigations.

@chrisballinger
Copy link
Member

I merged a patch that fixes the issue, and submitted a hotfix build 4.3.9 to Apple.

If you haven't already, please consider joining the TestFlight beta group: https://testflight.apple.com/join/psrh8VB6

Cheers!

@milkywade
Copy link

milkywade commented Aug 13, 2019

Hi - I updated both Bob and Alice's phones to 4.3.9. Alice's phone does not have an issue anymore. However Bob's phone is still not able to save all keys. iOS on both devices is 12.4. Bob can save them but when the application is started anew again, they appear again as in below screenshot.

cles_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants