Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a CI pipeline #18

Open
uivlis opened this issue Jan 9, 2021 · 3 comments
Open

Introduce a CI pipeline #18

uivlis opened this issue Jan 9, 2021 · 3 comments
Assignees

Comments

@uivlis
Copy link
Contributor

uivlis commented Jan 9, 2021

I think it might be a good idea to have a CI service perform a certain script for each PR/branch, like making sure solidity and js lint, or running coverage and asserting all tests pass with more than X% coverage. What do you think @robsecord?

@uivlis uivlis self-assigned this Jan 9, 2021
@Elyx0
Copy link
Contributor

Elyx0 commented Mar 10, 2021

That would be good as well as pre commit hooks that would do the same with husky

@Elyx0
Copy link
Contributor

Elyx0 commented Mar 25, 2021

Fist step could be installing https://github.com/typicode/husky to get pre-push hooks, have you given it more thougts @robsecord @uivlis ?

@uivlis
Copy link
Contributor Author

uivlis commented Jun 19, 2021

I'll add it to my queue (after a lot of other stuff) if @robsecord approves a Trello ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants