Dell OS9: bypass netmiko save_config #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on OS Version, Dnos9 may not support the command: `copy running-configuration startup-configuration`, instead abbreviating it as `copy running-config startup-config`. However, this asks for a confirmation. Instead, `write memory` does the same thing. This PR overrides the superclass so that we send `write memory` instead of calling out to the netmiko implementation. This should allow us to revert our netmiko patches, and use upstream directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on OS Version, Dnos9 may not support the command:
copy running-configuration startup-configuration, insteadabbreviating it as
copy running-config startup-config. However,this asks for a confirmation.
Instead,
write memorydoes the same thing.This PR overrides the superclass so that we send
write memoryinsteadof calling out to the netmiko implementation.
This should allow us to revert our netmiko patches, and use upstream
directly.