Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misuse of source in NetworkEvent::PubsubMessage #5072

Open
hanabi1224 opened this issue Dec 11, 2024 · 0 comments
Open

Misuse of source in NetworkEvent::PubsubMessage #5072

hanabi1224 opened this issue Dec 11, 2024 · 0 comments
Assignees
@lemmih
Labels
Type: Bug Something isn't working

Comments

@hanabi1224
Copy link
Contributor

hanabi1224 commented Dec 11, 2024 •
edited
Loading

Describe the bug

The source field in NetworkEvent::PubsubMessage is the propagation_source field in gossipsub::Event::Message which is

The peer that forwarded us this message.

https://docs.rs/libp2p-gossipsub/latest/libp2p_gossipsub/enum.Event.html#variants

It's unuseful but being misused in a few places as the true source of the pubsub message, we should just remove the field.

To reproduce

  1. Go to '...'
  2. Run '....'
  3. See error

Log output

Log Output 
paste log output...

Expected behaviour

Screenshots

Environment (please complete the following information):

  • OS:
  • Branch/commit
  • Hardware

Other information and links
@hanabi1224 hanabi1224 added the Type: Bug Something isn't working label Dec 11, 2024
@lemmih lemmih self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemmih lemmih

Labels
Type: Bug Something isn't working
Projects
Forest Backlog 🌲
Status: New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lemmih @hanabi1224