You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the implementations of Blockstore, PersistentStore and other interfaces are completely independent for MemoryDB and ParityDB. Which means that if we test e.g. GC on MemoryDB - it's not guaranteed to have the same behaviour on ParityDB.
Perhaps a different approach should be considered, where more of the DB logic is shared.
Could be completely generic across multiple databases. One way to achieve that is introducing a forest-specific (or chainsafe-specific) trait that all the database in question would implement. Then the implementation for many of the other traits could be based on the exposed interface as opposed to being database-specific.
The text was updated successfully, but these errors were encountered:
Currently the implementations of
Blockstore
,PersistentStore
and other interfaces are completely independent forMemoryDB
andParityDB
. Which means that if we test e.g. GC onMemoryDB
- it's not guaranteed to have the same behaviour onParityDB
.Perhaps a different approach should be considered, where more of the DB logic is shared.
For example the persistent storage fallback:
Could be completely generic across multiple databases. One way to achieve that is introducing a forest-specific (or chainsafe-specific) trait that all the database in question would implement. Then the implementation for many of the other traits could be based on the exposed interface as opposed to being database-specific.
The text was updated successfully, but these errors were encountered: