Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GC performance when loading a snapshot #2686

Closed
lemmih opened this issue Mar 20, 2023 · 4 comments
Closed

Improve GC performance when loading a snapshot #2686

lemmih opened this issue Mar 20, 2023 · 4 comments
Assignees

Comments

@lemmih
Copy link
Contributor

lemmih commented Mar 20, 2023

Issue summary

The semi-space GC loads snapshots into the "new" space rather than the "old" space. This immediately triggers a garbage collection run which isn't necessary and doesn't actually copy anything (yet still wastes a lot of resources). We should load snapshots into the "old" space.

Other information and links

@lemmih
Copy link
Contributor Author

lemmih commented Mar 20, 2023

Depends on #2638

@hanabi1224
Copy link
Contributor

We could maybe add fn is_empty() to Store trait. During GC, when old.is_empty() == true, delete it instead of doing walk_snapshot

@lemmih
Copy link
Contributor Author

lemmih commented Mar 20, 2023

I don't think that is sustainable. Conceptually, we really do want the snapshot data to be placed in the "old" space.

@hanabi1224 hanabi1224 self-assigned this Mar 31, 2023
@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Oct 3, 2023

The new, shiny GC (#3504) is on its way, which makes this issue no longer relevant.

@LesnyRumcajs LesnyRumcajs closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants