Fix/node version #309
Merged
Fix/node version #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRamanenkau
force-pushed
the
fix/node-version
branch
from
11e1ec3 to
c157230
Compare
yahortsaryk
approved these changes
Apr 22, 2024
MRamanenkau
pushed a commit
that referenced
this pull request
Apr 27, 2024
<!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. --------- Co-authored-by: rakanalh <[email protected]> Co-authored-by: Maksim Ramanenkau <[email protected]> Consolidating `master` and `dev` branches (#295) <!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [x] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. --------- Co-authored-by: rakanalh <[email protected]> Co-authored-by: Maksim Ramanenkau <[email protected]> fix: chainbridge's pallet storage prefixes fixed (#301) <!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. Set Balances storage version (#304) <!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. Fix/staking migrations (#300) This PR applies missing staking migrations with some changes in v9 and v11: 1. The migration to v9 has been altered to set the next pallet version only. The remaining parts are not needed because we are already using VoterList and it's in good condition. To change the migration, the source code has been moved from workplace dependencies to the Cere repo. 2. In migration to v11, there is no need to move data from BagsList to VoterList since we are already using VoterList. Instead, BagsList should be removed. 3. Benchmarking and Clippy checks are disabled for the sake of time. 4. Apply migrations to v8, v10, v12, v13. Notes: 1. BagsList has been migrated to VoterList in [v4.1.0](https://github.com/Cerebellum-Network/blockchain-node/compare/v4.0.0..v4.1.0#diff-8979c26ba42edc867488ec32089e6e48df0774444fe9a4726a09d129545060dbR1347) but the migration was not written and executed properly. 2. Staking pallet changes can be reviewed with `diff -r substrate/frame/staking blockchain-node/pallets/staking` or with [kdiff3](https://kdiff3.sourceforge.net/) if one prefers graphical UI. In both cases, you must have [Substrate](https://github.com/paritytech/substrate) locally. 3. To get back to the original staking pallet, [b80f635](b80f635), [5c8fcbd](5c8fcbd), and [1b71aa8](1b71aa8) should be reverted <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. Remove pallet society (#275) <!-- Describe what change this PR is implementing --> Seems like a useless pallet that nobody uses. Also requires migrations in v1.0.0 which i would rather remove the need for rather than keeping the pallet. <!--- What types of changes does your code introduce? --> - [x] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [x] Changelog doc updated. --------- Co-authored-by: Maksim Ramanenkau <[email protected]> Merging PR #305 to 'dev' branch (#306) Merging PR #305 <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. Fix build for release v5.2.0-rc1 (#308) <!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. Fix/node version (#309) <!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. Remove migration to v8 since it's already executed (#314) <!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
aie0
pushed a commit
that referenced
this pull request
Jun 24, 2024
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Migrations and Hooks
on_initializeon_finalizeChecklist