From 1ba3cdc8cb2ec800cf81fb497069fcbab3542f68 Mon Sep 17 00:00:00 2001 From: Ayush Mishra Date: Mon, 26 Aug 2024 18:27:30 +0530 Subject: [PATCH] Check for not-processed eras (#422) ## Description ## Types of Changes Please select the branch type you are merging and fill in the relevant template. - [ ] Hotfix - [ ] Release - [ ] Fix or Feature ## Fix or Feature ### Types of Changes - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist for Fix or Feature - [ ] Change has been tested locally. - [ ] Change adds / updates tests if applicable. - [ ] Changelog doc updated. - [ ] `spec_version` has been incremented. - [ ] `network-relayer`'s [events](https://github.com/Cerebellum-Network/network-relayer/blob/dev-cere/shared/substrate/events.go) have been updated according to the blockchain events if applicable. - [ ] All CI checks have been passed successfully ## Checklist for Hotfix - [ ] Change has been deployed to Testnet. - [ ] Change has been tested in Testnet. - [ ] Changelog has been updated. - [ ] Crate version has been updated. - [ ] `spec_version` has been incremented. - [ ] Transaction version has been updated if required. - [ ] Pull Request to `dev` has been created. - [ ] Pull Request to `staging` has been created. - [ ] `network-relayer`'s [events](https://github.com/Cerebellum-Network/network-relayer/blob/dev-cere/shared/substrate/events.go) have been updated according to the blockchain events if applicable. - [ ] All CI checks have been passed successfully ## Checklist for Release - [ ] Change has been deployed to Devnet. - [ ] Change has been tested in Devnet. - [ ] Change has been deployed to Qanet. - [ ] Change has been tested in Qanet. - [ ] Change has been deployed to Testnet. - [ ] Change has been tested in Testnet. - [ ] Changelog has been updated. - [ ] Crate version has been updated. - [ ] Spec version has been updated. - [ ] Transaction version has been updated if required. - [ ] All CI checks have been passed successfully --- pallets/ddc-verification/src/lib.rs | 18 ++++++++++++++++-- runtime/cere-dev/src/lib.rs | 2 +- runtime/cere/src/lib.rs | 2 +- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/pallets/ddc-verification/src/lib.rs b/pallets/ddc-verification/src/lib.rs index 976dc38a0..97ea14921 100644 --- a/pallets/ddc-verification/src/lib.rs +++ b/pallets/ddc-verification/src/lib.rs @@ -673,8 +673,22 @@ pub mod pallet { let batch_size = T::MAX_PAYOUT_BATCH_SIZE; let mut errors: Vec = Vec::new(); - let processed_dac_data = - Self::process_dac_data(&cluster_id, None, &dac_nodes, min_nodes, batch_size.into()); + let validated_era = + Self::get_era_for_payout(&cluster_id, EraValidationStatus::ValidatingData); + + let era_activity = if let Some((id, start, end)) = validated_era { + Some(EraActivity { id, start, end }) + } else { + None + }; + + let processed_dac_data = Self::process_dac_data( + &cluster_id, + era_activity, + &dac_nodes, + min_nodes, + batch_size.into(), + ); match processed_dac_data { Ok(Some(( diff --git a/runtime/cere-dev/src/lib.rs b/runtime/cere-dev/src/lib.rs index 2cd62d683..f6147081e 100644 --- a/runtime/cere-dev/src/lib.rs +++ b/runtime/cere-dev/src/lib.rs @@ -149,7 +149,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { // and set impl_version to 0. If only runtime // implementation changes and behavior does not, then leave spec_version as // is and increment impl_version. - spec_version: 54117, + spec_version: 54118, impl_version: 0, apis: RUNTIME_API_VERSIONS, transaction_version: 19, diff --git a/runtime/cere/src/lib.rs b/runtime/cere/src/lib.rs index 3cf3fe496..24a447851 100644 --- a/runtime/cere/src/lib.rs +++ b/runtime/cere/src/lib.rs @@ -143,7 +143,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { // and set impl_version to 0. If only runtime // implementation changes and behavior does not, then leave spec_version as // is and increment impl_version. - spec_version: 54116, + spec_version: 54118, impl_version: 0, apis: RUNTIME_API_VERSIONS, transaction_version: 19,