Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Remapping Code In Last Line Causes An Error #7

Open
PixTraveler opened this issue Apr 11, 2015 · 0 comments
Open

Removing Remapping Code In Last Line Causes An Error #7

PixTraveler opened this issue Apr 11, 2015 · 0 comments

Comments

@PixTraveler
Copy link

I created a simplified version of jQl that requires that the qdep function must be used to execute all dependent inline code and eliminates the code that automatically re-maps $, $(function(){...}), jQuery(function(){...}), and similar to call the jQL ready function.

This causes an error in lines like "if (typeof window.jQuery.fn == 'undefined')" when the jQuery name is not re-mapped and the boot function is called before jQuery is loaded. I have changed the line to "if (typeof window.jQuery == 'undefined' || typeof window.jQuery.fn == 'undefined')" in my code. I also changed two other similar lines.

Please consider making these three changes in the official code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant