Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to expand database of names? #84

Open
joshwlambert opened this issue Feb 1, 2024 · 1 comment
Open

Plans to expand database of names? #84

joshwlambert opened this issue Feb 1, 2024 · 1 comment

Comments

@joshwlambert
Copy link
Contributor

Is there any plan to increase the number of names? I often exceed the number of names (when sampling without replacement) and it would be great to know if there are plans to add more, or are you open to accepting contributions (for example for ethnicities currently not included)?

@dbetebenner
Copy link
Member

Hi Joshua,

Sorry for the slow reply.

  1. Regarding number of names. Let me dig into the examples you provided. In general, I thought previously that there were plenty of combinations (using first and last names) to suffice. But your example suggests that I might need to tweak with things to make sure that the combinations you want are satisfied.
  2. I'm definitely open to having addition names added. The current Arabic/middle-eastern addition was added as a suggestion.
    3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants