Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set.seed() only works for the first row of a dataframe. #73

Open
cfreder2 opened this issue Sep 27, 2021 · 1 comment
Open

set.seed() only works for the first row of a dataframe. #73

cfreder2 opened this issue Sep 27, 2021 · 1 comment

Comments

@cfreder2
Copy link

Neat package.

One minor thing, running this will result in a different person for the second row of the dataframe. The seed is only respected for the first run.

set.seed(1842)
randomNames(2, which.names = "both", return.complete.data = T)

The workaround:
set.seed(1842)
df1 <- bind_rows(randomNames(1, gender = T, ethnicity = T, which.names = "both", return.complete.data = T),
randomNames(1, gender = T, ethnicity = T, which.names = "both", return.complete.data = T),
randomNames(1, gender = T, ethnicity = T, which.names = "both", return.complete.data = T))

Any thoughts on allowing us to set the seed so we can always reproduce the same set of names?

@dbetebenner
Copy link
Member

Thanks for the comment.

I'm not sure I understand the way in which you want the function to produce results.

When I run your first example

set.seed(1842)
randomNames(2, which.names = "both", return.complete.data = T)

I get

> set.seed(1842)
> randomNames(2, which.names = "both", return.complete.data = T)
   gender ethnicity first_name   last_name
1:      0         6    Annnees al-Muhammad
2:      1         6      Suhaa    el-Basha

If I run it again I get the same thing.

> set.seed(1842)
> randomNames(2, which.names = "both", return.complete.data = T)
   gender ethnicity first_name   last_name
1:      0         6    Annnees al-Muhammad
2:      1         6      Suhaa    el-Basha

I'm not getting a different person for the second row of the dataframe. Can you clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants