Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track: when reset the resource update in progress flag upon runtime restarts, check libvirt domain update status #56

Open
yb01 opened this issue Aug 31, 2020 · 0 comments

Comments

@yb01
Copy link
Collaborator

yb01 commented Aug 31, 2020

Track todo item in metadata/client.go:
Verify libvirt domain update info or callbacks status before reset the resource update in progress flag if libvirt is still updating it, the don't reset it.

will need some research here in libvirt. the callbacks in libvirt current don't seem offer this status check. so this will be the best effort approach, i.e. if there is no such functionality, we will force reset it. our logic in the CRI should skip this if the resource level is the same. so this is just for further optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant