Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL pipeline failure #9

Closed
Caroline-99 opened this issue Nov 15, 2024 · 6 comments
Closed

CL pipeline failure #9

Caroline-99 opened this issue Nov 15, 2024 · 6 comments
Assignees

Comments

@Caroline-99
Copy link

image
@aleixpuigb
Copy link
Collaborator

We should only add the CL_agreed TRUE, otherwise we might encounter more CL label repetitions.

@hkir-dev
Copy link
Contributor

hkir-dev commented Dec 2, 2024

In the HLCA source file there are two clusters annotated as bronchial goblet cell and CL_agreed TRUE (line 27 and 29), that seems to be the reason.

Is this a copy error made by me, should I keep only one of these?

Also, David mentioned:

If markers are going into CL there needs to be a single cluster per dataset + the CL mapping could differ from CxG.

@aleixpuigb
Copy link
Collaborator

One is a more specific term that is not CL agreed.

@hkir-dev
Copy link
Contributor

hkir-dev commented Dec 2, 2024

Sorry, I couldn't understand the solution. Should I make the first one False?

index cl_class cl_label Cell_type Marker_set Minimal_markers Minimal_markers_label Organ ... CL_agreed
27 CL:1000312 bronchial goblet cell Goblet (bronchial) CLM:1000026 ensembl:ENSG00000197943|ensembl:ENSG00000174501 PLCG2|ANKRD36C Lung ... True
29 CL:1000312 bronchial goblet cell Goblet (subsegmental) CLM:1000028 ensembl:ENSG00000255823|ensembl:ENSG00000149021 MTRNR2L8|SCGB1A1 Lung ... True

@aleixpuigb
Copy link
Collaborator

I think this is because the problem with the PR incorporating commits from a different branch. CLM:1000028 should have remained False.
image

hkir-dev added a commit that referenced this issue Dec 2, 2024
aleixpuigb added a commit that referenced this issue Dec 2, 2024
This commit shoul fix the error in CL #9 and obophenotype/cell-ontology#2772
hkir-dev added a commit that referenced this issue Dec 2, 2024
@hkir-dev
Copy link
Contributor

hkir-dev commented Dec 2, 2024

resolved by #13

@hkir-dev hkir-dev closed this as completed Dec 2, 2024
hkir-dev added a commit that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants