Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Result in reader.rs #46

Open
CeleritasCelery opened this issue Dec 8, 2023 · 0 comments
Open

Use Result in reader.rs #46

CeleritasCelery opened this issue Dec 8, 2023 · 0 comments

Comments

@CeleritasCelery
Copy link
Owner

Currently the reader has a defined type for errors, but it is stored as part of the Token enum. This is not idiomatic Rust. A better way to handle this would be to have the reader functions return a Result<Token, Error>. This would let us take advantage of the try operator (?) and have more idiomatic code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant