Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support edits to Device definitions without stopping ALabOS #27

Open
rekumar opened this issue Jul 31, 2023 · 1 comment
Open

Support edits to Device definitions without stopping ALabOS #27

rekumar opened this issue Jul 31, 2023 · 1 comment
Assignees
Labels
feature request new feature to implement

Comments

@rekumar
Copy link
Collaborator

rekumar commented Jul 31, 2023

Similar need to #26 , but implementation will differ. Mainly because BaseDevices must be instantiated and held to maintain connections to physical devices.

There are two needs here, both to be supported while ALabOS is running:

  • edit existing device definitions (main priority)
  • add/remove devices from the lab (lower priority, as this suggests physical updates to the lab which should imply work stoppage anyways).

Proposed solution for edits:

  • Create a function reload_device(device_name: str) which disconnects device, reloads device definition, reconnects device
  • Create a button on the dashboard to execute this function. Maybe require device to be paused first?

Proposed solution for add/remove (less clear tbh but here is an idea):

  • Create a function to reload the device configuration file, look for changes. On new devices, just load them and add to ALabOS mongodb device collection. On removed devices, push a notification to the GUI "this device is slated for removal, please pause". Once pause status is achieved, it will be dropped from the dashboard + collection.
@rekumar rekumar self-assigned this Aug 10, 2023
@rekumar
Copy link
Collaborator Author

rekumar commented Aug 10, 2023

Updated plan. We will support device reloading as described above. To add/remove devices from the lab, one must stop ALabOS. This will require a system pause button that will allow ongoing tasks to complete, then a clean stop/restart state so the lab can be reset.

@bernardusrendy bernardusrendy added the feature request new feature to implement label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request new feature to implement
Projects
None yet
Development

No branches or pull requests

2 participants