-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ComparativePieWidgetUI #510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3549580545
💛 - Coveralls |
…comparative-pie-widget
@VictorVelarde test for comparative Pie Widget UI are now ready. I've added a small change to test utils to support this, let know if you find any problem with that pls. |
VictorVelarde
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice, thx for contributing Juan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements part of the work proposed in RFC #479
Changes added in this PR include:
ComparativePieWidgetUI
in thewidgets
folderComparativePieWidgetUI
ComparativePieWidgetUI
ComparativePieWidgetUI
ComparativePieWidgetUI
where all prop combinations can be tested and tweaked. A screenshot of this storybook is added as visual feedback.Type of change
Acceptance
yarn storybook:start
in thereact-ui
folder.ComparativePieWidgetUI
in your sample project, by importingComparativePieWidgetUI
from@carto/react-ui
. You can use this branch ofcarto-react-template
to skip this step if you want, as a test screen is already setup there. Bear in mind that if this feature is not published to npm you will have to link your local version of@carto/react-*
packages withyarn link
.Basic checklist