feat(sources): Move sources from @deck.gl/carto #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
commented
Oct 31, 2024
donmccurdy
commented
Oct 31, 2024
donmccurdy
commented
Oct 31, 2024
|
@padawannn I've reverted the coverage change in this PR and moved that into #29 with more explanation! |
zbigg
reviewed
Nov 5, 2024
| @@ -62,6 +61,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@deck.gl/aggregation-layers": "^9.0.30", | |||
| "@deck.gl/carto": "^9.0.30", | |||
There was a problem hiding this comment.
Hmm, i'm wondering.
Shouldn't we remove this dependency?
It seems like now we would have circular dep ... even if in devDepencies
There was a problem hiding this comment.
The dev dependency is only here (after this PR) because we need it in examples...
https://github.com/CartoDB/carto-api-client/blob/main/examples/01-pure-js/pure-js.ts
... and it's a bit hard to test the layer sources without that. So it won't be a "circular dependency" for users of either package, I think that should be OK?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves functions dealing with the CARTO API from
@deck.gl/cartointo@carto/api-client, intending that the@deck.gl/cartomodule can be more focused on visualization. For backwards compatibility, the@deck.gl/cartomodule will depend on@carto/api-clientand re-export the functions it previously provided. The source code in this PR is minimally changed for TypeScript compiler settings and some cleanup; the unit tests required a more extensive rewrite to move from Tape to Vitest.