Time change: discrepancy between appt slot time and displayed time

[lslavice]

We’re seeing this on the ENGR 101 queue, where a student signed up for a time slot at 8:30pm but the displayed time in the “claim” box says 9:30pm

[CarsonHoffman]

Ah, shoot—I thought I had caught all the issues around daylight savings, but it looks like this is a straggler. This has to do with how the scheduled time of the appointment is calculated on the back-end, but the front-end uses the time of the timeslot (rather than the time of the specific appointment) to display times, meaning that the time above the box is the correct time. The appointments affected by this already have their scheduled times set in stone, meaning that I can't directly deploy a fix for this today, but this shouldn't have any impact starting tomorrow (and until the next switch); I'll keep this issue open to not lose track of it. Thank you for pointing this out!

[lslavice]

Thanks for the quick response! Just to be clear, the correct time in this screenshot would be the 8:30pm time?

…

---- Typed in a hurry on my phone. Please excuse errors.

On Mar 14, 2021, at 1:32 PM, Carson Hoffman ***@***.***> wrote:  Ah, shoot—I thought I had caught all the issues around daylight savings, but it looks like this is a straggler. This has to do with how the scheduled time of the appointment is calculated on the back-end, but the front-end uses the time of the timeslot (rather than the time of the specific appointment) to display times, meaning that the time above the box is the correct time. The appointments affected by this already have their scheduled times set in stone, meaning that I can't directly deploy a fix for this today, but this shouldn't have any impact starting tomorrow (and until the next switch); I'll keep this issue open to not lose track of it. Thank you for pointing this out! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[CarsonHoffman]

This issue went a bit deeper than I had originally thought—it also showed the incorrect time to students, so I went ahead and deployed a hot-fix in f0b8445 (and changed the times of the existing student appointments manually). Any new appointments should now take on the correct time—let me know if you're still having issues!

[lslavice]

Okay, thanks so much!

…

---- Typed in a hurry on my phone. Please excuse errors.

On Mar 14, 2021, at 2:00 PM, Carson Hoffman ***@***.***> wrote:  This issue went a bit deeper than I had originally thought—it also showed the incorrect time to students, so I went ahead and deployed a hot-fix in f0b8445 (and changed the times of the existing student appointments manually). Any new appointments should now take on the correct time—let me know if you're still having issues! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.