Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_samples is shown in the example configs but it isn't supported by the main branch #27

Open
mikeogezi opened this issue Nov 7, 2023 · 0 comments

Comments

@mikeogezi
Copy link

mikeogezi commented Nov 7, 2023

save_samples: False

save_samples is not supported by the main branch. When in the config, it causes the following error:

Traceback (most recent call last):
  File "/home/ogezi/miniconda3/lib/python3.9/runpy.py", line 188, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/ogezi/miniconda3/lib/python3.9/runpy.py", line 111, in _get_module_details
    __import__(pkg_name)
  File "/home/ogezi/projects/Freda/relations-encoding/spatial_rl.py", line 135, in <module>
    config = DRLXConfig.load_yaml("configs/ddpo_sd.yml")
  File "/home/ogezi/miniconda3/lib/python3.9/site-packages/drlx/configs.py", line 325, in load_yaml
    return cls.from_dict(config)
  File "/home/ogezi/miniconda3/lib/python3.9/site-packages/drlx/configs.py", line 354, in from_dict
    train=TrainConfig.from_dict(config["train"]),
  File "/home/ogezi/miniconda3/lib/python3.9/site-packages/drlx/configs.py", line 12, in from_dict
    return cls(**cfg)
TypeError: __init__() got an unexpected keyword argument 'save_samples'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant