-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-4318: network flooding test #1864
base: main
Are you sure you want to change the base?
A0-4318: network flooding test #1864
Conversation
This reverts commit 74fc9b0.
… before and after finalization tests
… instead of just `expected finalized block`
…docker-compose_network_flooding_test.yml
…/nightly-normal-session-e2e-tests.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I hate it.
sender: S, | ||
data_from_user: mpsc::UnboundedReceiver<D>, | ||
) -> Result<(), ProtocolError<PK>> { | ||
info!(target: "network-clique-flooder", "Starting the flooder for the Aleph-bft network."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, I kinda hate that our code now contains (optional) malicious parts within it. Nothing to do about it, just venting, resolve this comment.
Description
Type of change
Please delete options that are not relevant.
Checklist:
IMPORTANT: pipeline test result https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/12051718872/job/33604011550
You can test it locally:
and watch net-out stats for Node3 using
docker stats
.