Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-4318: network flooding test #1864

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

fixxxedpoint
Copy link
Contributor

@fixxxedpoint fixxxedpoint commented Nov 27, 2024

Description

  • An implementation of network flooding routines for both alephbft and substrate based networks. They try to flood all other nodes using some valid messages (messages are updated to newest available from normal protocol invocations).
  • A dockerized nightly e2e-test that invokes the flooding routine for a single validator and checks if nodes were able to process a full session.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests

IMPORTANT: pipeline test result https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/12051718872/job/33604011550

You can test it locally:

cargo build --package aleph-node --release --locked
docker build -t aleph-node:latest -f docker/Dockerfile .
cargo build --package aleph-node --release --locked --features network_flooding_test
docker build -t aleph-node:flooding -f docker/Dockerfile .
DOCKER_COMPOSE=docker/docker-compose_network_flooding_test.yml ./.github/scripts/run_consensus.sh

and watch net-out stats for Node3 using docker stats.

… instead of just `expected finalized block`
Copy link
Contributor

@timorleph timorleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I hate it.

sender: S,
data_from_user: mpsc::UnboundedReceiver<D>,
) -> Result<(), ProtocolError<PK>> {
info!(target: "network-clique-flooder", "Starting the flooder for the Aleph-bft network.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I kinda hate that our code now contains (optional) malicious parts within it. Nothing to do about it, just venting, resolve this comment.

e2e-tests/Cargo.lock Show resolved Hide resolved
.github/actions/run-e2e-test/action.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants